rich/r0b3BOT
1
0 Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 5 Wiki Activity

r0b3BOT does not handle homeassistant API failure gracefully #3

New Issue
Closed
opened 2019-11-22 13:45:42 +00:00 by Rich · 11 comments
Rich commented 2019-11-22 13:45:42 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

We are not gracefully handling the failure of a homeassistant API request. The user is not notified of the issue and the command fails to run at all. We should be able to at the very least continue to pull the printer image and status details from Octoprint.

Error seen in console when API failure occurs:

Printstat_console_error

User experience when API failure occurs:

Printstat_User_exp

We are not gracefully handling the failure of a homeassistant API request. The user is not notified of the issue and the command fails to run at all. We should be able to at the very least continue to pull the printer image and status details from Octoprint. Error seen in console when API failure occurs: ![Printstat_console_error](/uploads/7ccdec4cf463ca1523bfadd2dfb6da85/Printstat_console_error.png) User experience when API failure occurs: ![Printstat_User_exp](/uploads/b3b03fa21d0b10479bbcf1204856da10/Printstat_User_exp.png)
Rich commented 2019-11-22 13:46:33 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

created branch 3-r0b3bot-does-not-handle-homeassistant-api-failure-gracefully to address this issue

created branch [`3-r0b3bot-does-not-handle-homeassistant-api-failure-gracefully`](/Bots/r0b3BOT/compare/master...3-r0b3bot-does-not-handle-homeassistant-api-failure-gracefully) to address this issue
Rich commented 2019-11-22 14:11:10 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in merge request !1

mentioned in merge request !1
Rich commented 2019-11-22 14:11:26 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

closed via merge request !1

closed via merge request !1
Rich commented 2019-11-22 14:11:26 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in commit 54d69b0151

mentioned in commit 54d69b0151bdca36419e9c7127bc6a2ffadb8557
Rich commented 2019-11-22 14:14:29 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in merge request !2

mentioned in merge request !2
Rich commented 2019-11-22 14:14:36 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in commit 4945714e4c

mentioned in commit 4945714e4c75438dc072e591e0119f0a37333faf
Rich commented 2019-11-22 14:28:24 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in merge request !3

mentioned in merge request !3
Rich commented 2019-11-22 14:28:30 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in commit 6719847896

mentioned in commit 67198478965dd996136dc3388cb825fae82d1811
Rich commented 2019-11-22 14:40:25 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in merge request !5

mentioned in merge request !5
Rich commented 2019-11-22 14:41:29 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in commit f22591aee0

mentioned in commit f22591aee08024129379c8a7dfaeaa92b6629971
Rich commented 2019-11-22 14:47:36 +00:00 (Migrated from gitlab.rickelobe.com)
Copy link
Copy source

mentioned in issue #2

mentioned in issue #2
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
Breaking Bug
Bug
Feature Request
No labels Bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
rich (Rich Oberholtzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rich/r0b3BOT#3