Jean-Pierre MartineauandClaude Opus 5.5
11b5274b31
Each test docstring states the behaviour that the test proves, in the simple present. No assertion message, test id, or other string literal changed. Four statements now agree with the code: the Trace highlight stays on the last row, a menu count, and two others. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
438 lines
18 KiB
Python
438 lines
18 KiB
Python
# SPDX-License-Identifier: Apache-2.0
|
|
"""Tests for the seam between a tool's answer and its rendering.
|
|
|
|
In :mod:`meshterm.ui.report`, a tool states what it found. :mod:`meshterm.ui.fields`
|
|
defines the shapes of that statement, one time for each shape. :mod:`meshterm.ui.renderers`
|
|
changes the statement to bytes. The design depends on this claim: **one typed row has two
|
|
projections**. Thus almost each test here builds one report and checks both faces of it.
|
|
A rule that is true for only one face is the drift that this design replaced.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import io
|
|
import json
|
|
from datetime import datetime, timezone
|
|
|
|
import pytest
|
|
|
|
from meshterm.ui import fields, script
|
|
from meshterm.ui.renderers import JsonRenderer, OutputFormat, PlainRenderer, for_format
|
|
from meshterm.ui.report import BARE, SILENT, Column, Facts, Lane, Listing
|
|
|
|
_WHEN = datetime(2026, 9, 7, 22, 22, 41, tzinfo=timezone.utc)
|
|
|
|
|
|
def _plain(*blocks) -> str: # noqa: ANN002 - the blocks differ in each test
|
|
"""Render a report through the plain face and return the output."""
|
|
buffer = io.StringIO()
|
|
PlainRenderer(script.console(buffer)).render(blocks)
|
|
buffer.flush()
|
|
return buffer.getvalue()
|
|
|
|
|
|
def _json(*blocks): # noqa: ANN002, ANN202 - the blocks differ in each test
|
|
"""Render a report through the machine face and return the parsed document."""
|
|
buffer = io.StringIO()
|
|
JsonRenderer(script.console(buffer)).render(blocks)
|
|
lines = [line for line in buffer.getvalue().splitlines() if line]
|
|
assert len(lines) == 1, lines
|
|
return json.loads(lines[0])
|
|
|
|
|
|
def _contacts(rows) -> Listing: # noqa: ANN001 - the rows differ in each test
|
|
"""A listing in the shape that ``contacts`` uses: a node, an age, and a count."""
|
|
return Listing(
|
|
key="contacts",
|
|
columns=(
|
|
fields.node(
|
|
"node",
|
|
lanes=(("name", "NAME"), ("type", "TYPE"), ("hash", "HASH"), ("key", "KEY")),
|
|
),
|
|
fields.when("heard_at", "HEARD", absent="never"),
|
|
fields.integer("packets", "PKTS"),
|
|
),
|
|
rows=rows,
|
|
order=("NAME", "TYPE", "HEARD", "PKTS", "HASH", "KEY"),
|
|
)
|
|
|
|
|
|
_ALICE = {
|
|
"node": fields.NodeRef(name="Alice", key="d4" * 32, hash="d4", type="node"),
|
|
"heard_at": _WHEN,
|
|
"packets": 12,
|
|
}
|
|
|
|
|
|
# -- one row, two faces ----------------------------------------------------------------
|
|
|
|
|
|
def test_one_typed_row_reaches_both_faces_without_either_parsing_the_other() -> None:
|
|
"""The seam exists for this claim: a row holds the value and not a rendering of it.
|
|
|
|
The plain face writes ``+5.1``. A user compares a column of readings by eye only when
|
|
each reading shows its sign. The document writes ``5.1``, because a number has its own
|
|
sign. A function cannot find one output from the other without a parser. The two
|
|
hand-written ``if ctx.json_output:`` branches were such parsers.
|
|
"""
|
|
block = Listing(key="hops", columns=(fields.snr("snr_db", "SNR_DB"),), rows=[{"snr_db": 5.14}])
|
|
assert _plain(block).splitlines()[1].strip() == "+5.1"
|
|
assert _json(block) == [{"snr_db": 5.1}]
|
|
|
|
|
|
def test_a_node_is_one_object_however_many_columns_it_is_worth() -> None:
|
|
"""One machine key and four plain lanes: this is the purpose of :func:`fields.node`.
|
|
|
|
Each listing that mentions a node asks for the same column. Thus ``jq '.[].node.key'``
|
|
reads the same on contacts, courier, and monitor, and a consumer writes its node handler
|
|
one time. Only the room that the surface has for the node is different.
|
|
"""
|
|
header, record = _plain(_contacts([_ALICE])).splitlines()
|
|
assert header.split() == ["NAME", "TYPE", "HEARD", "PKTS", "HASH", "KEY"]
|
|
assert len(record.split()) == len(header.split())
|
|
assert "Alice" in record and "d4" * 32 in record
|
|
assert _json(_contacts([_ALICE]))[0]["node"] == {
|
|
"name": "Alice",
|
|
"key": "d4" * 32,
|
|
"hash": "d4",
|
|
"type": "node",
|
|
"self": False,
|
|
}
|
|
|
|
|
|
def test_a_listing_may_draw_its_lanes_in_an_order_the_document_does_not_use() -> None:
|
|
"""``contacts`` puts HEARD and PKTS between the TYPE and the HASH of a node.
|
|
|
|
The order of the lanes is a decision for reading: the fields that a user scans first go
|
|
on the left. The order of the keys belongs to the document. If the two orders were tied
|
|
together, we would have to make one face worse.
|
|
"""
|
|
header = _plain(_contacts([_ALICE])).splitlines()[0].split()
|
|
assert header.index("HEARD") < header.index("HASH")
|
|
assert list(_json(_contacts([_ALICE]))[0]) == ["node", "heard_at", "packets"]
|
|
|
|
|
|
def test_a_listing_refuses_an_order_that_does_not_name_its_own_lanes() -> None:
|
|
"""A typo here draws a listing with a missing column and gives no error.
|
|
|
|
A header line cannot show this failure, because the records still align, under the wrong
|
|
headings. Thus the listing catches the typo where the code writes it.
|
|
"""
|
|
with pytest.raises(ValueError, match="every lane"):
|
|
Listing(
|
|
key="x",
|
|
columns=(fields.integer("a", "A"), fields.integer("b", "B")),
|
|
order=("A", "NOPE"),
|
|
)
|
|
|
|
|
|
# -- absences --------------------------------------------------------------------------
|
|
|
|
|
|
def test_the_two_faces_spell_absence_in_their_own_alphabets() -> None:
|
|
"""A user learns ``-`` one time. A parser already has ``null``.
|
|
|
|
The fact is the same, and neither face must know the token of the other face. For this
|
|
reason the plain ``-`` never reaches a document as a string.
|
|
"""
|
|
empty = {"node": None, "heard_at": None, "packets": None}
|
|
record = _plain(_contacts([empty])).splitlines()[1]
|
|
assert record.split() == ["-", "unknown", "never", "-", "-", "-"]
|
|
assert _json(_contacts([empty]))[0] == {"node": None, "heard_at": None, "packets": None}
|
|
|
|
|
|
def test_a_word_standing_in_for_an_absence_stays_a_word_only_on_the_plain_face() -> None:
|
|
"""``unknown`` is a word that a user acts on. A consumer already has ``null`` for it.
|
|
|
|
If the document had both, a program would have two spellings for one fact, and a special
|
|
case to remember for each field.
|
|
"""
|
|
row = {"node": fields.NodeRef(hash="a1")}
|
|
block = Listing(key="n", columns=(fields.node("node", lanes=(("type", "TYPE"),)),), rows=[row])
|
|
assert _plain(block).splitlines()[1].strip() == "unknown"
|
|
assert _json(block)[0]["node"]["type"] is None
|
|
|
|
|
|
def test_a_never_heard_node_is_a_fact_and_an_undated_row_is_an_absence() -> None:
|
|
"""These are two different things, and the age lane shows which one, with no second column.
|
|
|
|
A node that was never heard has a heard-age. A row that has no such time does not. If
|
|
both used ``-``, "we have not heard from it" and "this kind of row has no heard time"
|
|
would be the same reading.
|
|
"""
|
|
assert script.age(None, absent="never") == "never"
|
|
assert script.age(None) == script.NONE
|
|
|
|
|
|
def test_info_leaves_out_a_reading_the_radio_does_not_answer_for_and_json_keeps_the_key() -> None:
|
|
"""The only deliberate disagreement between the faces, and the reason for it.
|
|
|
|
A missing plain key says "this radio does not report it". A dash would say that the
|
|
radio reported nothing. A user can act on this difference. A consumer cannot. Also, a
|
|
set of keys that changes costs the consumer a membership test for each field. Thus the
|
|
document keeps the key and writes ``null``.
|
|
"""
|
|
block = Facts(
|
|
key="info",
|
|
fields=(fields.word("model", "model"), fields.integer("uptime_s", "uptime_s")),
|
|
values={"model": None, "uptime_s": 42},
|
|
omit_absent=True,
|
|
)
|
|
assert _plain(block).split() == ["uptime_s", "42"]
|
|
assert _json(block) == {"model": None, "uptime_s": 42}
|
|
|
|
|
|
# -- facts, bare and silent ------------------------------------------------------------
|
|
|
|
|
|
def test_a_get_prints_its_value_alone_and_still_documents_the_key() -> None:
|
|
"""The caller named the key, so a repeat of the key is one more thing to remove.
|
|
|
|
``$(meshterm config get name)`` needs no removal. This argument is only about shell
|
|
substitution. A JSON consumer does not do shell substitution. Thus the document keeps
|
|
the key, the type, and the label that the bare form removed.
|
|
"""
|
|
block = Facts(
|
|
key="setting",
|
|
fields=(
|
|
fields.word("key", "key"),
|
|
fields.word("value", "value"),
|
|
fields.hidden("type"),
|
|
),
|
|
values={"key": "tx_power", "value": "20", "type": "int"},
|
|
shape=BARE,
|
|
bare="value",
|
|
)
|
|
assert _plain(block).strip() == "20"
|
|
assert _json(block) == {"key": "tx_power", "value": "20", "type": "int"}
|
|
|
|
|
|
def test_a_bare_answer_with_nothing_in_it_prints_nothing_at_all() -> None:
|
|
"""A node that never answered, a slot with nothing in it, and no single dash.
|
|
|
|
The bare form prints the value. If there is no value, the exit status is the whole
|
|
report, and stdout stays empty. The document still has the shape, with ``null`` where
|
|
the answer would be, because a consumer that branches on the key needs it.
|
|
"""
|
|
block = Facts(
|
|
key="remote",
|
|
fields=(fields.word("command", "command"), fields.word("reply", "reply")),
|
|
values={"command": "get name", "reply": None},
|
|
shape=BARE,
|
|
bare="reply",
|
|
)
|
|
assert _plain(block) == ""
|
|
assert _json(block) == {"command": "get name", "reply": None}
|
|
|
|
|
|
def test_an_acknowledgement_prints_nothing_and_is_still_a_document() -> None:
|
|
"""A user can act on an answer that prints nothing. A program cannot.
|
|
|
|
``config advert`` says everything in its exit status, and that is the correct plain
|
|
answer. A caller that must log what was sent has no place to read it. The document is
|
|
for this case.
|
|
"""
|
|
block = Facts(
|
|
key="advert",
|
|
fields=(fields.flag("sent", "sent"), fields.flag("flood", "flood")),
|
|
values={"sent": True, "flood": False},
|
|
shape=SILENT,
|
|
)
|
|
assert _plain(block) == ""
|
|
assert _json(block) == {"sent": True, "flood": False}
|
|
|
|
|
|
# -- several blocks --------------------------------------------------------------------
|
|
|
|
|
|
def test_a_single_block_report_is_its_block_and_nothing_around_it() -> None:
|
|
"""``meshterm contacts --json | jq '.[].node.name'`` reads as it looks.
|
|
|
|
There is no envelope. The report that a caller needs is ``$?``, the same as without the
|
|
flag. Thus a caller does not look inside anything to get the answer.
|
|
"""
|
|
assert isinstance(_json(_contacts([_ALICE])), list)
|
|
|
|
|
|
def test_several_blocks_make_one_object_with_the_facts_at_its_top_level() -> None:
|
|
"""A trace is a set of facts and a table for each hop, and the document shows both.
|
|
|
|
The facts block is the set of facts about the one thing that the command answered. Thus
|
|
it is the document, and not a part inside the document. A listing needs a name, and it
|
|
takes its own key.
|
|
"""
|
|
facts = Facts(
|
|
key="trace", fields=(fields.flag("success", "success"),), values={"success": True}
|
|
)
|
|
edges = Listing(key="edges", columns=(fields.integer("index", "HOP"),), rows=[{"index": 0}])
|
|
assert _json(facts, edges) == {"success": True, "edges": [{"index": 0}]}
|
|
assert _plain(facts, edges).splitlines() == ["success yes", "", "HOP", " 0"]
|
|
|
|
|
|
def test_a_block_drawn_only_for_a_person_never_reaches_the_document() -> None:
|
|
"""The closing summary of ``monitor`` for each node comes from the records above it.
|
|
|
|
If the stream printed the summary as a second shape of line in the middle of the stream,
|
|
each consumer would need a discriminator that it does not need otherwise. Thus the plain
|
|
face keeps the summary, and the stream stays uniform.
|
|
"""
|
|
facts = Facts(
|
|
key="window", fields=(fields.integer("packets", "packets"),), values={"packets": 2}
|
|
)
|
|
summary = Listing(
|
|
key="heard",
|
|
columns=(fields.integer("packets", "PKTS"),),
|
|
rows=[{"packets": 2}],
|
|
plain_only=True,
|
|
)
|
|
assert "PKTS" in _plain(facts, summary)
|
|
assert _json(facts, summary) == {"packets": 2}
|
|
|
|
|
|
def test_a_block_that_prints_nothing_leaves_no_blank_line_where_it_stood() -> None:
|
|
"""The separator depends on what the renderer drew, not on the index of the block.
|
|
|
|
``config restore --dry-run`` states its outcome silently and its plan as a listing. A
|
|
count of positions made the command start with an empty line. That line was output that
|
|
the command did not have, for the program that read it.
|
|
"""
|
|
silent = Facts(
|
|
key="restore", fields=(fields.flag("dry_run", "dry_run"),), values={}, shape=SILENT
|
|
)
|
|
plan = Listing(
|
|
key="operations",
|
|
columns=(fields.word("operation", "OPERATION"),),
|
|
rows=[{"operation": "set"}],
|
|
)
|
|
assert _plain(silent, plan).splitlines()[0] == "OPERATION"
|
|
|
|
|
|
# -- the document's own rules ----------------------------------------------------------
|
|
|
|
|
|
def test_a_document_is_one_compact_line_that_never_escapes_a_name() -> None:
|
|
r"""A node name in Cyrillic is a node name, not a run of ``\\uXXXX``.
|
|
|
|
The document is one line. Thus a program reads a stream and a one-shot answer in the
|
|
same way, and ``jq .`` can indent the document for a user with no cost. Nothing can
|
|
change a document that was pretty-printed across four hundred lines back to a stream.
|
|
"""
|
|
buffer = io.StringIO()
|
|
row = {"node": fields.NodeRef(name="Наблюдатель", hash="c3")}
|
|
block = Listing(key="n", columns=(fields.node("node"),), rows=[row])
|
|
JsonRenderer(script.console(buffer)).render((block,))
|
|
out = buffer.getvalue()
|
|
assert out.endswith("\n") and out.count("\n") == 1
|
|
assert "Наблюдатель" in out
|
|
assert ", " not in out and ": " not in out
|
|
|
|
|
|
def test_every_time_in_a_document_is_utc_to_the_second() -> None:
|
|
"""Twenty characters, always, so a string comparison is a time comparison.
|
|
|
|
A local offset is a fact about the machine that ran the command, not about the event.
|
|
Two hosts that ask the same radio the same question must make the same document.
|
|
"""
|
|
stamped = _json(_contacts([_ALICE]))[0]["heard_at"]
|
|
assert stamped == "2026-09-07T22:22:41Z"
|
|
assert len(stamped) == 20
|
|
|
|
|
|
def test_a_time_whose_offset_we_do_not_know_is_absent_on_both_faces() -> None:
|
|
"""A naive datetime is not a fact, and neither face can make up an offset for it."""
|
|
naive = {"node": None, "heard_at": datetime(2026, 9, 7, 22, 22, 41), "packets": None}
|
|
assert "2026" not in _plain(_contacts([naive]))
|
|
assert _json(_contacts([naive]))[0]["heard_at"] is None
|
|
|
|
|
|
def test_a_concept_may_have_a_face_on_only_one_side() -> None:
|
|
"""This is true in both directions, and each direction has a real call site.
|
|
|
|
The DESCRIPTION of a preference is prose for the person who chooses a value. It has
|
|
nothing that a program can branch on. The declared type of a setting is the opposite.
|
|
The document needs this fact, but a user who prints ``config show`` does not.
|
|
"""
|
|
block = Listing(
|
|
key="prefs",
|
|
columns=(
|
|
fields.word("key", "PREFERENCE"),
|
|
fields.note("help", "DESCRIPTION"),
|
|
fields.hidden("type"),
|
|
),
|
|
rows=[{"key": "trace_cooldown_s", "help": "Wait this long", "type": "int"}],
|
|
)
|
|
assert "Wait this long" in _plain(block)
|
|
assert _json(block) == [{"key": "trace_cooldown_s", "type": "int"}]
|
|
|
|
|
|
# -- streams ---------------------------------------------------------------------------
|
|
|
|
|
|
def _stream_listing() -> Listing:
|
|
"""A live listing in the shape that ``monitor`` uses: pinned lanes, with the name last."""
|
|
return Listing(
|
|
key="observations",
|
|
columns=(
|
|
fields.instant("observed_at", "TIME"),
|
|
fields.node("node", lanes=(("hash", "NODE"), ("name", "NAME"))),
|
|
),
|
|
order=("TIME", "NODE", "NAME"),
|
|
)
|
|
|
|
|
|
def test_a_stream_pins_its_lanes_because_the_widths_arrive_with_the_data() -> None:
|
|
"""A live capture has no moment when "each record is in", and that is when columns get a size.
|
|
|
|
Both streams were once joined with a gutter and had no alignment. Thus a name in one of
|
|
them still had its quotes, because nothing else showed where the field ended.
|
|
"""
|
|
buffer = io.StringIO()
|
|
listing = _stream_listing()
|
|
with PlainRenderer(script.console(buffer)).stream(listing) as row:
|
|
row({"observed_at": _WHEN, "node": fields.NodeRef(name="Alice", hash="d4e5f6a7")})
|
|
row({"observed_at": _WHEN, "node": fields.NodeRef(name="A Very Long Node Name", hash="c3")})
|
|
header, first, second = buffer.getvalue().splitlines()
|
|
assert header.split() == ["TIME", "NODE", "NAME"]
|
|
assert first.index("d4e5f6a7") == second.index("c3")
|
|
|
|
|
|
def test_a_streamed_document_is_one_record_per_line_all_the_same_shape() -> None:
|
|
"""A consumer reads line by line and never asks which type of record it has."""
|
|
buffer = io.StringIO()
|
|
listing = _stream_listing()
|
|
with JsonRenderer(script.console(buffer)).stream(listing) as row:
|
|
row({"observed_at": _WHEN, "node": fields.NodeRef(hash="d4")})
|
|
row({"observed_at": _WHEN, "node": fields.NodeRef(hash="a1")})
|
|
documents = [json.loads(line) for line in buffer.getvalue().splitlines()]
|
|
assert [set(d) for d in documents] == [{"observed_at", "node"}] * 2
|
|
assert [d["node"]["hash"] for d in documents] == ["d4", "a1"]
|
|
|
|
|
|
# -- the boundary ----------------------------------------------------------------------
|
|
|
|
|
|
def test_the_format_picks_the_renderer_and_nothing_else_does() -> None:
|
|
"""One choice, made one time, in the one place that knows what the caller asked for."""
|
|
console = script.console(io.StringIO())
|
|
assert isinstance(for_format(OutputFormat.PLAIN, console), PlainRenderer)
|
|
assert isinstance(for_format(OutputFormat.JSON, console), JsonRenderer)
|
|
|
|
|
|
def test_a_tool_with_no_scripted_face_renders_nothing_at_all() -> None:
|
|
"""The map and the dashboard state no report, and both renderers must accept this."""
|
|
assert _plain() == ""
|
|
buffer = io.StringIO()
|
|
JsonRenderer(script.console(buffer)).render(None)
|
|
assert buffer.getvalue() == ""
|
|
|
|
|
|
def test_a_lane_and_a_column_are_separable_so_a_third_format_needs_neither() -> None:
|
|
"""The purpose of the split, as a test: a format is a function of the typed row.
|
|
|
|
A renderer for CSV would read the same columns and rows, and write its own cells. The
|
|
report knows nothing about a gutter, a comma, or a brace.
|
|
"""
|
|
column = Column(key="n", lanes=(Lane(header="N", render=lambda v: f"<{v}>"),))
|
|
assert column.lanes[0].render(3) == "<3>"
|
|
assert column.json(3) == 3
|