agessaman
0ff3408564
Stored 0 was the shipped default from 2026-01-02 to 2026-03-28, and every association path has run it with power save off since. Reading it as MIN_MODEM, as F11 did, would have put every node set up in that window into modem sleep on its next association. 0 now reads as `none`, and `set wifi.powersave min` stores a new value 3. /mqtt.json accepts 0..3; older firmware repairs 3 to `none` on load. Binary snapshots are no longer written, so 3 never reaches a legacy layout.
77 lines
2.5 KiB
C++
77 lines
2.5 KiB
C++
#pragma once
|
|
|
|
#include <stdint.h>
|
|
#include <string.h>
|
|
|
|
// The single mapping between the stored `wifi.powersave` preference, its CLI
|
|
// name, and the IDF power-save mode.
|
|
//
|
|
// Pure lookup so host tests can hold startup, reconnect, CLI and web config to
|
|
// one table: they used to map the same stored value differently, so a node set
|
|
// to `min` silently ran with power save off after its first reconnect while
|
|
// `get wifi.powersave` still said min.
|
|
//
|
|
// Stored values are fleet state — never renumber them. 0 was the shipped
|
|
// default from 2026-01-02 to 2026-03-28, and every association path ran it with
|
|
// power save off, so it keeps meaning `none`; an explicit `min` is stored as 3.
|
|
// Older firmware repairs 3 to `none` when it loads /mqtt.json.
|
|
namespace WifiPowerSavePolicy {
|
|
|
|
enum StoredValue : uint8_t {
|
|
kLegacyDefault = 0, // WIFI_PS_NONE: the old default, never an operator choice
|
|
kNone = 1, // WIFI_PS_NONE (default)
|
|
kMax = 2, // WIFI_PS_MAX_MODEM
|
|
kMin = 3, // WIFI_PS_MIN_MODEM
|
|
kMaxStoredValue = kMin,
|
|
};
|
|
|
|
// Mirrors wifi_ps_type_t. MQTTBridge.cpp static_asserts these against the SDK.
|
|
enum Mode : uint8_t {
|
|
kModeNone = 0,
|
|
kModeMinModem = 1,
|
|
kModeMaxModem = 2,
|
|
};
|
|
|
|
// Anything outside the known range reads as the default rather than as the
|
|
// lowest-numbered mode, so a corrupt byte cannot silently enable modem sleep.
|
|
static inline Mode modeFor(uint8_t stored) {
|
|
switch (stored) {
|
|
case kMin: return kModeMinModem;
|
|
case kMax: return kModeMaxModem;
|
|
case kNone: return kModeNone;
|
|
default: return kModeNone;
|
|
}
|
|
}
|
|
|
|
static inline const char* nameFor(uint8_t stored) {
|
|
switch (stored) {
|
|
case kMin: return "min";
|
|
case kMax: return "max";
|
|
case kNone: return "none";
|
|
default: return "none";
|
|
}
|
|
}
|
|
|
|
// Parses a CLI argument, which may be followed by trailing text (the observer
|
|
// setters take the rest of the command line). Returns false and leaves *out
|
|
// untouched for anything else.
|
|
static inline bool parseName(const char* value, uint8_t* out) {
|
|
if (value == nullptr || out == nullptr) return false;
|
|
static const struct { const char* name; uint8_t stored; } kNames[] = {
|
|
{ "min", kMin },
|
|
{ "none", kNone },
|
|
{ "max", kMax },
|
|
};
|
|
for (unsigned i = 0; i < sizeof(kNames) / sizeof(kNames[0]); i++) {
|
|
const size_t len = strlen(kNames[i].name);
|
|
if (strncmp(value, kNames[i].name, len) == 0 &&
|
|
(value[len] == '\0' || value[len] == ' ')) {
|
|
*out = kNames[i].stored;
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
} // namespace WifiPowerSavePolicy
|