Refactor MQTT origin handling to use effective origin logic

Updated MyMesh implementations in simple_repeater and simple_room_server to set mqtt_origin to an empty string, allowing the effective origin to follow node_name during publishing. Introduced new functions in MQTTBridge to manage effective origin retrieval and refresh from preferences, ensuring consistent behavior across MQTT operations. This change simplifies the origin management and enhances clarity in the codebase.
This commit is contained in:
agessaman committed 2026-05-09 17:06:00 -07:00
1 parent b37db66830
commit ff031f48bb
5 files changed
+46 -18

No files matched your search

+2 -6
View File
@@ -682,8 +682,8 @@ MyMesh::MyMesh(mesh::MainBoard &board, mesh::Radio &radio, mesh::MillisecondCloc
_prefs.bridge_baud = 115200; // baud rate
_prefs.bridge_channel = 1; // channel 1
// MQTT defaults (same as repeater)
StrHelper::strncpy(_prefs.mqtt_origin, "MeshCore-RoomServer", sizeof(_prefs.mqtt_origin));
// MQTT defaults (same as repeater; empty mqtt_origin follows node_name when publishing)
_prefs.mqtt_origin[0] = '\0';
StrHelper::strncpy(_prefs.mqtt_iata, "SEA", sizeof(_prefs.mqtt_iata));
_prefs.mqtt_status_enabled = 1; // enabled
_prefs.mqtt_packets_enabled = 1; // enabled
@@ -755,10 +755,6 @@ void MyMesh::begin(FILESYSTEM *fs) {
applyGpsPrefs();
#endif
#ifdef WITH_MQTT_BRIDGE
// Set MQTT origin to actual device name (not build-time ADVERT_NAME) - same as repeater
StrHelper::strncpy(_prefs.mqtt_origin, _prefs.node_name, sizeof(_prefs.mqtt_origin));
MESH_DEBUG_PRINTLN("MQTT origin set to device name: %s", _prefs.mqtt_origin);
if (_prefs.bridge_enabled) {
// Defer construction to avoid static init crashes on ESP32 classic
bridge = new MQTTBridge(&_prefs, _mgr, getRTCClock(), &self_id);