fix(network): rebuild the DHCP hostname when the node is renamed
The hostname was built once in begin() from the node name, so `set name` left the node advertising its old name to DHCP until the next reflash. It is now rebuilt on rename through a new CommonCLICallbacks::onNodeNameChanged() hook, and begin() shares the same helper. What this cannot do is rename a live lease. IDF 4.4 states that a hostname changed after the interface is up "would only be reflected once the interface restarts/reconnects", and Arduino 2.x's WiFi.setHostname() does not touch a running netif at all — it writes a static string that the netif reads at bring-up. Forcing the issue would mean bouncing the link, which costs every MQTT slot a reconnect; that is not a reasonable price for a rename, so the new name lands at the next reconnect or boot instead. Only automatic (Ethernet-preferred) links carry a hostname today, exactly as before. Giving plain Wi-Fi observers one would change the DHCP identity of the existing fleet and is a separate decision.
This commit is contained in:
1 parent
c781862362
commit
da6406e92f
6 files changed
+75
-10
No files matched your search
@@ -1583,6 +1583,7 @@ void CommonCLI::handleSetCmd(uint32_t sender_timestamp, char* command, char* rep
|
||||
if (isValidName(&config[5])) {
|
||||
StrHelper::strncpy(_prefs->node_name, &config[5], sizeof(_prefs->node_name));
|
||||
savePrefs();
|
||||
_callbacks->onNodeNameChanged();
|
||||
strcpy(reply, "OK");
|
||||
} else {
|
||||
strcpy(reply, "Error, bad chars");
|
||||
|
||||
@@ -274,6 +274,10 @@ struct LegacyObserverTail {
|
||||
class CommonCLICallbacks {
|
||||
public:
|
||||
virtual void savePrefs() = 0;
|
||||
// The node name feeds the DHCP hostname, which is built once when the link
|
||||
// starts. Renaming a running node has to rebuild it or the node keeps
|
||||
// advertising the old name to DHCP until the next reflash.
|
||||
virtual void onNodeNameChanged() {}
|
||||
#ifdef WITH_MQTT_BRIDGE
|
||||
virtual bool saveObserverPrefs() = 0;
|
||||
#else
|
||||
|
||||
Reference in new issue
Block a user