Preserve contacts when source discovery is unknown

Do not classify legacy or page-name stat errors as unread payloads. Keep candidate contact files unchanged, retry source selection, and use bounded volatile operation if authority remains unknown. Cover legacy absence, downgrade leftovers, cleanup-time metadata recovery and persistent faults with actual-source sanitizer tests and restored-bug negative controls.
This commit is contained in:
mikecarper committed 2026-10-16 08:38:26 -07:00
1 parent 54a5137032
commit b393737593
4 files changed
+153 -6

No files matched your search

+5 -3
View File
@@ -2369,14 +2369,14 @@ void DataStore::loadContacts(DataStoreHost* host) {
MESH_DEBUG_PRINTLN(
"DataStore: HIL injecting contact page %u stat failure", page);
_contact_load_incomplete = true;
_unread_contact_pages.mark(page);
queueContactRecovery();
return;
}
#endif
if (!contactPathPresence(contacts_fs, path, page_exists)) {
_contact_load_incomplete = true;
_unread_contact_pages.mark(page);
// Discovery failed before the contact source was selected. This is not
// evidence that the page payload is unreadable or safe to discard.
queueContactRecovery();
return;
}
@@ -2388,7 +2388,9 @@ void DataStore::loadContacts(DataStoreHost* host) {
bool migration_marker_exists = false;
if (!contactPathPresence(contacts_fs, "/contacts3", legacy_exists)) {
_contact_load_incomplete = true;
queueContactRecovery(true);
// Unknown legacy presence does not make readable pages expendable: they
// may be the only authoritative store. Retry without authorizing erasure.
queueContactRecovery();
return;
}
if (!contactPathPresence(contacts_fs, CONTACT_MIGRATION_MARKER,