Keep guest-password room logins out of the durable replay store
On a room server the guest password grants Read/Write, which the login replay store treats as a role that needs a durable record. Every new guest-password identity therefore took one of the 128 permanent slots, and once they were used up the store failed closed for every new identity, including a new administrator device, until the filesystem was erased. Rooms often publish the guest password. A guest-password Read/Write session (one without explicitly assigned permissions) now uses the policy public readers already use: it must beat its in-boot timestamp and any record the identity already has, which is still advanced, but it never creates a new record. Administrator logins and explicitly assigned roles keep the durable reservation and still fail closed on a full store. Tests: test_room_login_replay_capacity.py runs the real room login handler against the real ClientACL replay store with ASan/UBSan: guest churn cannot lock out a new admin or assigned writer, a former admin's record still binds guest-password logins, and a store full of privileged records still refuses a new admin. It fails 2 of 3 on the previous code. Two expectations in test_room_login_integration.py and the login profile contract follow the new policy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
0e72474f41
commit
6b61e28404
5 files changed
+273
-4
No files matched your search
@@ -244,6 +244,7 @@ jobs:
|
||||
python3 -B test/test_room_post_permissions.py -v
|
||||
python3 -B test/test_room_login_authorization.py -v
|
||||
python3 -B test/test_room_login_integration.py -v
|
||||
python3 -B test/test_room_login_replay_capacity.py -v
|
||||
python3 -B test/test_room_client_paths.py -v
|
||||
python3 -B test/test_client_acl_infrastructure.py -v
|
||||
python3 -B test/test_stored_client_reply_routes.py -v
|
||||
|
||||
Reference in new issue
Block a user