From 6ad3e349ac90721213b7effa1a269d955904709d Mon Sep 17 00:00:00 2001 From: mikecarper Date: Mon, 26 Oct 2026 00:39:57 -0700 Subject: [PATCH] Align room-post regression with admin-only reply overrides Fix the stale assertion reported by Actions run 40283205754. Ordinary room posts and topic pushes retain their configured delivery copies and ACK/retry behavior without opting into the admin CLI tx.reply policy. All 18 room-client path tests pass. --- test/test_room_client_paths.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test_room_client_paths.py b/test/test_room_client_paths.py index 4d116934d..df3e3d09f 100644 --- a/test/test_room_client_paths.py +++ b/test/test_room_client_paths.py @@ -252,7 +252,8 @@ static void pushCases() { assert(mesh.sent[0].retry_enabled && !mesh.sent[1].retry_enabled && mesh.retry_timestamp == 700); assert(c.extra.room.push_post_timestamp == 700 && c.extra.room.pending_topic_revision == 22); assert(c.extra.room.pending_ack != 0 && c.extra.room.ack_timeout == ticks + PUSH_TIMEOUT_BASE + 2 * PUSH_ACK_TIMEOUT_FACTOR); - assert(mesh.sent[0].packet.radio_reply && mesh.sent[1].packet.radio_reply); + // Room posts use their delivery routes, not the admin CLI tx.reply override. + assert(!mesh.sent[0].packet.radio_reply && !mesh.sent[1].packet.radio_reply); assert(memcmp(mesh.sent[0].packet.payload, mesh.sent[1].packet.payload, mesh.sent[0].packet.payload_len) == 0); MyMesh failed; failed.send_ok = false; assert(!failed.pushRoomTextToClient(&failed.acl.clients[0], 700, author, "hello room", 22));