From 5cadf3d96b1333963d002b57d1ac03ef4b4fd5b8 Mon Sep 17 00:00:00 2001 From: agessaman Date: Sun, 23 Nov 2025 11:11:53 -0800 Subject: [PATCH] Convert IATA codes to uppercase in CommonCLI and MQTTBridge for consistency --- src/helpers/CommonCLI.cpp | 4 ++++ src/helpers/bridges/MQTTBridge.cpp | 9 +++++++++ 2 files changed, 13 insertions(+) diff --git a/src/helpers/CommonCLI.cpp b/src/helpers/CommonCLI.cpp index e415e7005..70ababd1b 100644 --- a/src/helpers/CommonCLI.cpp +++ b/src/helpers/CommonCLI.cpp @@ -853,6 +853,10 @@ void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, ch strcpy(reply, "OK"); } else if (memcmp(config, "mqtt.iata ", 10) == 0) { StrHelper::strncpy(_prefs->mqtt_iata, &config[10], sizeof(_prefs->mqtt_iata)); + // Convert IATA code to uppercase (IATA codes are conventionally uppercase) + for (int i = 0; _prefs->mqtt_iata[i]; i++) { + _prefs->mqtt_iata[i] = toupper(_prefs->mqtt_iata[i]); + } savePrefs(); strcpy(reply, "OK"); } else if (memcmp(config, "mqtt.status ", 12) == 0) { diff --git a/src/helpers/bridges/MQTTBridge.cpp b/src/helpers/bridges/MQTTBridge.cpp index 13065c797..6418cd819 100644 --- a/src/helpers/bridges/MQTTBridge.cpp +++ b/src/helpers/bridges/MQTTBridge.cpp @@ -137,6 +137,11 @@ void MQTTBridge::begin() { stripQuotes(_iata, sizeof(_iata)); MQTT_DEBUG_PRINTLN("IATA after stripping: '%s'", _iata); + // Convert IATA code to uppercase (IATA codes are conventionally uppercase) + for (int i = 0; _iata[i]; i++) { + _iata[i] = toupper(_iata[i]); + } + // Update enabled flags from preferences _status_enabled = _prefs->mqtt_status_enabled; _packets_enabled = _prefs->mqtt_packets_enabled; @@ -1038,6 +1043,10 @@ void MQTTBridge::setOrigin(const char* origin) { void MQTTBridge::setIATA(const char* iata) { strncpy(_iata, iata, sizeof(_iata) - 1); _iata[sizeof(_iata) - 1] = '\0'; + // Convert IATA code to uppercase (IATA codes are conventionally uppercase) + for (int i = 0; _iata[i]; i++) { + _iata[i] = toupper(_iata[i]); + } } void MQTTBridge::setDeviceID(const char* device_id) {