From 5990b4c5fd6b11cd64780ecc23e8f5087689e25d Mon Sep 17 00:00:00 2001
From: mikecarper <mikecarper@gmail.com>
Date: Tue, 6 Oct 2026 10:11:41 -0700
Subject: [PATCH] Keep telemetry permission fixtures aligned with production
 prefs

---
 .../test_sensor_reply_bounds.cpp              | 24 +++++++++++++++++--
 test/test_sensor_reply_bounds.py              | 15 ++++++++++++
 2 files changed, 37 insertions(+), 2 deletions(-)

diff --git a/test/fixtures/sensor_reply_bounds/test_sensor_reply_bounds.cpp b/test/fixtures/sensor_reply_bounds/test_sensor_reply_bounds.cpp
index f1ec4843..fc5da983 100644
--- a/test/fixtures/sensor_reply_bounds/test_sensor_reply_bounds.cpp
+++ b/test/fixtures/sensor_reply_bounds/test_sensor_reply_bounds.cpp
@@ -9,12 +9,12 @@
 #include <helpers/sensors/LPPDataHelpers.h>
 
 #include "telemetry_capacity.inc"
+#include "telemetry_access.inc"
 #define REQ_TYPE_GET_TELEMETRY_DATA SENSOR_REQ_TYPE_GET_TELEMETRY_DATA
 #define PERM_ACL_GUEST 0
 #define REQ_TYPE_GET_AVG_MIN_MAX 0x04
 #define PERM_ACL_ROLE_MASK 7
 #define PERM_ACL_READ_ONLY 1
-#define TELEMETRY_ACCESS_ALL 2
 #define TELEM_PERM_BASE 1
 #define TELEM_PERM_LOCATION 2
 #define TELEM_PERM_ENVIRONMENT 4
@@ -83,8 +83,10 @@ struct Telemetry {
 };
 struct Sensors {
   std::vector<uint8_t> body;
+  uint8_t last_permissions = 0;
   void requestGpsTelemetryTimeSync(uint32_t) {}
-  void querySensors(uint8_t, Telemetry& telemetry) {
+  void querySensors(uint8_t permissions, Telemetry& telemetry) {
+    last_permissions = permissions;
     if (telemetry.data.size() + body.size() <= telemetry.max_len)
       telemetry.data.insert(telemetry.data.end(), body.begin(), body.end());
   }
@@ -320,6 +322,24 @@ int main(int argc, char** argv) {
     target.empty_real_series = true;
     assert(target.handleRequest(&client, 51, REQ_TYPE_GET_AVG_MIN_MAX, query, sizeof(query)) == 8);
   }
+  else if (!strcmp(argv[1], "permissions")) {
+    for (uint8_t mode : {uint8_t(TELEMETRY_ACCESS_ALL), uint8_t(TELEMETRY_ACCESS_ACL)}) {
+      for (uint8_t role : {uint8_t(PERM_ACL_GUEST), uint8_t(PERM_ACL_READ_ONLY), uint8_t(3)}) {
+        SensorMesh target;
+        ClientInfo client;
+        client.permissions = role;
+        target._prefs.telemetry_access = mode;
+        const bool allowed = mode == TELEMETRY_ACCESS_ALL || role >= PERM_ACL_READ_ONLY;
+        uint8_t mask = 0;
+        const unsigned length = target.handleRequest(&client, 51, REQ_TYPE_GET_TELEMETRY_DATA, &mask, 1);
+        assert(length == (allowed ? 8u : 4u));
+        assert(target.sensors.last_permissions == (allowed ? 7 : 0));
+        uint8_t query[10] = {};
+        const unsigned history_length = target.handleRequest(&client, 51, REQ_TYPE_GET_AVG_MIN_MAX, query, sizeof(query));
+        assert((history_length != 0) == (role >= PERM_ACL_READ_ONLY));
+      }
+    }
+  }
   else if (!strcmp(argv[1], "packet")) {
     SensorMesh target;
     ClientInfo client;
diff --git a/test/test_sensor_reply_bounds.py b/test/test_sensor_reply_bounds.py
index 7a274ed3..84cbedf9 100644
--- a/test/test_sensor_reply_bounds.py
+++ b/test/test_sensor_reply_bounds.py
@@ -67,6 +67,17 @@ def production_capacities(sensor_transform=None, room_transform=None):
     return "\n".join(definitions) + "\n"
 
 
+def production_telemetry_access():
+    source = (ROOT / "src/helpers/CommonCLI.h").read_text()
+    definitions = []
+    for mode in ("ALL", "ACL"):
+        matches = re.findall(r"^#define TELEMETRY_ACCESS_" + mode + r"\s+[0-9]+\s*$", source, re.M)
+        if len(matches) != 1:
+            raise AssertionError("one production telemetry access mode required: " + mode)
+        definitions.append(matches[0].strip())
+    return "\n".join(definitions) + "\n"
+
+
 class SensorReplyBoundsTest(unittest.TestCase):
     def execute(self, case, transform=None, room_transform=None):
         compiler = shutil.which("g++") or shutil.which("clang++")
@@ -74,6 +85,7 @@ class SensorReplyBoundsTest(unittest.TestCase):
         with tempfile.TemporaryDirectory(prefix="sensor-reply-bounds-") as directory:
             work = Path(directory)
             (work / "telemetry_capacity.inc").write_text(production_capacities(transform, room_transform), encoding="ascii")
+            (work / "telemetry_access.inc").write_text(production_telemetry_access(), encoding="ascii")
             (work / "production.inc").write_text(production_methods(transform, room_transform), encoding="ascii")
             history_types = (ROOT / "examples/simple_sensor/TimeSeriesData.h").read_text()
             history_types = "\n".join(line for line in history_types.splitlines() if not line.startswith("#"))
@@ -117,6 +129,9 @@ class SensorReplyBoundsTest(unittest.TestCase):
     def test_empty_history_query_has_no_synthetic_zero_values(self):
         self.check_case("empty")
 
+    def test_telemetry_permission_modes_match_current_prefs(self):
+        self.check_case("permissions")
+
     def test_old_telemetry_copy_exceeds_route_admission(self):
         def old(source):
             begin = source.index("    const uint8_t* tbuf = telemetry.getBuffer();")